Merged
Conversation
for more information, see https://pre-commit.ci
Collaborator
Author
|
Or we include the key "shape" in the Worker configuration, although it can be guess from poni. This way the diffmap files generated by the next version will be compatible with previous versions |
kif
approved these changes
Jan 24, 2025
Member
kif
left a comment
kif
left a comment
There was a problem hiding this comment.
LGTM
I am considering many other changes in this part ...
I would rather keep the worker configuration in a centralized place.
So maybe it will change in the (near) future.
Member
|
I foresee to keep track of the shape of the processed images in the worker. There is a PR on the topic to create this entry in the WorkerConfig dataclass but it is not yet used/populated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.